Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(git): ignores node_modules folder #62

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Apr 1, 2020

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31 timbru31 merged commit 10f8626 into master Apr 1, 2020
@timbru31 timbru31 deleted the fix/gitignore branch April 1, 2020 10:23
@raphinesse
Copy link
Contributor

To late to the party it seems. As this package doesn't have any dependencies, I don't see where that node_modules/ dir would come from. But then again: no harm done in ignoring it anyway.

@timbru31
Copy link
Member Author

timbru31 commented Apr 1, 2020

The dir comes from locally developing/fiddling with the project and doing an npm i inside the template folder.

@raphinesse
Copy link
Contributor

Funny that npm actually creates a lock file and a node modules folder when there are no dependencies at all 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants