[CURATOR-493] Fix test case with testDeleteChildrenConcurrently #291
Conversation
| if ( stat == null ) | ||
| { | ||
| // the thread client has begin deleted the children | ||
| threadDeleted = true; |
There was a problem hiding this comment.
What's the point of this? Once it is set, checkExists() is never called again. That seems incorrect. I removed this and the test still passes. Can you explain?
There was a problem hiding this comment.
The point is that judge the new thread is running at the loop that is deleting children:
ZKPaths.java , 341 line
for ( String child : children )
{
String fullPath = makePath(path, child);
deleteChildren(zookeeper, fullPath, true);
}
and then, the main thread is try to delete some child that is still not deleted by the new thread. If the main thread delete child successfully, the new thread should not throw NoNodeException, but the old version will throw NoNodeException and cause the remaining children are not deleted, that's the bug situation.
So, it's unnecessary to checkExists() after that threadDeleted is true. I just want the main thread delete a child successfully, when the new thread is deleting children.
Link #235