Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codestyle CI check #1438

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix codestyle CI check #1438

merged 1 commit into from
Sep 22, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 21, 2024

For reasons I don't understand and can't replicate, #1437 caused CI on main to start failing the codestyle CI check.

Here is an example failure: https://github.com/sqlparser-rs/sqlparser-rs/actions/runs/10971828683/job/30467402220

Run cargo +nightly fmt -- --check --config-path <(echo 'license_template_path = "HEADER"')
No such file or directory (os error 2)
Error: Process completed with exit code 1.

That PR did pass the codestyle check (CI run here) 🤷

# it's an unstable feature.
rust-version: nightly
- run: cargo +nightly fmt -- --check --config-path <(echo 'license_template_path = "HEADER"')
- run: cargo fmt -- --check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears the option in question was removed some time ago from rustfmt: rust-lang/rustfmt#5103

Thus let's simply simplify the CI rule

@alamb alamb changed the title Fix fmt CI check Fix codestyle CI check Sep 21, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10972721284

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.351%

Totals Coverage Status
Change from base Build 10971828683: 0.0%
Covered Lines: 29687
Relevant Lines: 33225

💛 - Coveralls

@alamb alamb merged commit affe8b5 into apache:main Sep 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants