-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor code refactoring #2428
Merged
Merged
Minor code refactoring #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
============================================
- Coverage 55.14% 55.06% -0.09%
+ Complexity 5274 5268 -6
============================================
Files 573 573
Lines 25459 25460 +1
Branches 4537 4533 -4
============================================
- Hits 14039 14019 -20
- Misses 9327 9348 +21
Partials 2093 2093
Continue to review full report at Codecov.
|
diecui1202
reviewed
Sep 3, 2018
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvoker.java
Show resolved
Hide resolved
It looks good to me. |
zzzzhougit
pushed a commit
to zzzzhougit/incubator-dubbo
that referenced
this pull request
Sep 9, 2018
* Polish. No functional change. * Remove unnecessary null check. * Use standard Integer.compareTo(). * Remove unecessary null check. * Remove unnecessary unboxing. * Code simplification. * Remove unnecessary codes. * Fix typo. * Wrap the text. * Fix typo. * Make the variables private. * Code simplification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Minor code refactoring, no functional change. All of them are reported by IntelliJ IDEA.
Brief changelog
Verifying this change
It should have no functional change.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.