Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #2488

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Update readme #2488

merged 2 commits into from
Sep 12, 2018

Conversation

kun-song
Copy link
Contributor

What is the purpose of the change

Correct some typos.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Sep 11, 2018

Codecov Report

Merging #2488 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2488      +/-   ##
============================================
- Coverage     55.03%   55.01%   -0.03%     
+ Complexity     5268     5267       -1     
============================================
  Files           573      573              
  Lines         25454    25454              
  Branches       4520     4520              
============================================
- Hits          14009    14003       -6     
- Misses         9350     9355       +5     
- Partials       2095     2096       +1
Impacted Files Coverage Δ Complexity Δ
...onfig/spring/extension/SpringExtensionFactory.java 75% <0%> (-10.72%) 10% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 57.5% <0%> (-8.75%) 21% <0%> (-2%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-4.17%) 3% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 57.89% <0%> (-1.06%) 18% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 69.28% <0%> (+0.74%) 63% <0%> (+1%) ⬆️
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 64.51% <0%> (+6.45%) 3% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyClient.java 81.35% <0%> (+8.47%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2f34e...5e3c1b8. Read the comment docs.

@diecui1202
Copy link

looks good to me.

@diecui1202 diecui1202 merged commit e1e6978 into apache:master Sep 12, 2018
@kun-song kun-song deleted the update-readme branch September 12, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants