Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3744]Create constants for 'hash.names' and 'hash.arguments' (#3744) #3758

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

danielamorais
Copy link

@danielamorais danielamorais commented Mar 27, 2019

What is the purpose of the change

fix #3744

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request. Please merge it if the UT passed.

@codecov-io
Copy link

Codecov Report

Merging #3758 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3758      +/-   ##
============================================
- Coverage     63.59%   63.59%   -0.01%     
  Complexity       71       71              
============================================
  Files           704      704              
  Lines         31069    31063       -6     
  Branches       5037     5037              
============================================
- Hits          19757    19753       -4     
  Misses         9037     9037              
+ Partials       2275     2273       -2
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/apache/dubbo/common/Constants.java 93.33% <ø> (ø) 0 <0> (ø) ⬇️
...cluster/loadbalance/ConsistentHashLoadBalance.java 87.75% <100%> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...he/dubbo/qos/server/handler/QosProcessHandler.java 55.88% <0%> (-1.27%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-0.73%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 62.2% <0%> (-0.59%) 0% <0%> (ø)
...rpc/cluster/loadbalance/RoundRobinLoadBalance.java 79.68% <0%> (-0.32%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 75.51% <0%> (+0.68%) 0% <0%> (ø) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 67.92% <0%> (+0.94%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab27a39...56af21b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

应该使用常量代替
4 participants