-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRESOLVER-461] Cleanup in dep managers #402
Conversation
3 of them were almost same. --- https://issues.apache.org/jira/browse/MRESOLVER-461
There is no logical change, but only pulled up to a super class? |
Yes, a cleanup |
thing is: will do resolver - maven - IT run to test classic, but other two was never tested (so i can be only certain did not break them). Will also add UTs as only classic has rudimentary one |
OK, the resolver master - maven master - maven IT master ran OK, so this shows that "classic" was undisturbed. Next will do UTs and will merge this as I have your approvals. |
Is another trick for Maven2 backward compatiblity
Removed |
3 of them were almost same.
Note: "derives" means picks up depMgt from currently processed node. Hence, classic ignores all depMgt in graph coming from transitive dependencies. depth=1 is root (ie. project), depth=2 are first level deps (those listed in POM), etc.
https://issues.apache.org/jira/browse/MRESOLVER-461