[MRESOLVER-467][MRESOLVER-468] Pull out shared HTTP stuff #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have 3 HTTP transports and each have quite some overlap. Pull these out, introduce new "shared HTTP" module for those. --- https://issues.apache.org/jira/browse/MRESOLVER-467
michael-o
reviewed
Jan 23, 2024
| @Singleton | ||
| @Named | ||
| public final class DefaultChecksumExtractor implements ChecksumExtractor { | ||
| private final Map<String, Strategy> strategies; |
There was a problem hiding this comment.
Why do you need this empty interface?
There was a problem hiding this comment.
To distinguish component types, otherwise on inject it would be a loop -> failure (entry point would like to inject itself), hence using subtype. Also, later on, the Strategy interface MAY become different, while currently it does not.
There was a problem hiding this comment.
You are right, separated them out.
cstamas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have 3 HTTP transports and each have quite some overlap. Pull these out. Included checksums in all three, but Jetty and JDK transports also redefine same constants as well.
Another issue touched here is "stabilizing" (and exposing intermediate components) on RepositorySystem supplier.
https://issues.apache.org/jira/browse/MRESOLVER-467
https://issues.apache.org/jira/browse/MRESOLVER-468