-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #9115] Optimize the broker's reverse notification for consumerId change #9116
base: develop
Are you sure you want to change the base?
Conversation
…nsumerId change
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9116 +/- ##
=============================================
- Coverage 48.09% 47.97% -0.12%
+ Complexity 12077 12050 -27
=============================================
Files 1320 1320
Lines 92840 92867 +27
Branches 11898 11900 +2
=============================================
- Hits 44654 44557 -97
- Misses 42694 42797 +103
- Partials 5492 5513 +21 ☔ View full report in Codecov by Sentry. |
if so, task2 will never be interrupted, but it is better than now |
Hi, thank you for your review. I added the atomic check here. Please help review it again. Thank you. |
LGTM |
|
||
private final AtomicBoolean interrupted = new AtomicBoolean(false); | ||
|
||
private final List<Channel> channels; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the role of channels in NotifyTaskControl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that when a new notification task arrives, the channels in the old notification task are no longer notified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is controlled by the interrupted flag? once the interrupted flag is true, the for loop will be break.
Fixes #9115 .