Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8589] Optimize RocksDB CQ shutdown when using DoubleWriteCQ #9212

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8589

Brief Description

How Did You Test This Change?

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.03%. Comparing base (5936695) to head (3e37d96).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9212      +/-   ##
=============================================
- Coverage      48.07%   48.03%   -0.04%     
+ Complexity     12100    12092       -8     
=============================================
  Files           1321     1321              
  Lines          93080    93080              
  Branches       11933    11933              
=============================================
- Hits           44745    44709      -36     
- Misses         42806    42837      +31     
- Partials        5529     5534       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lollipopjin lollipopjin merged commit 66d4a26 into apache:develop Feb 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support JSON CQ Files and offset In-place Upgrade to RocksDB
4 participants