Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[SPARK-34549][BUILD] Upgrade aws kinesis to 1.14.0 and java sdk 1.11.844" #33145

Closed
wants to merge 1 commit into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jun 30, 2021

What changes were proposed in this pull request?

This PR reverts the change of SPARK-34549 ( #31658).

Why are the changes needed?

See #33133.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Confirmed all the *Kinesis*Suite pass with the following command without newer Guava.

ENABLE_KINESIS_TESTS=1 KINESIS_TEST_ENDPOINT_URL=https://kinesis.ap-northeast-1.amazonaws.com build/sbt -Pkinesis-asl 'testOnly *Kinesis*Suite'

@github-actions github-actions bot added the BUILD label Jun 30, 2021
@sarutak
Copy link
Member Author

sarutak commented Jun 30, 2021

cc: @HyukjinKwon @dongjoon-hyun @viirya
I'll check if all the kinesis tests work on AWS environment.

@HyukjinKwon HyukjinKwon changed the title Revert SPARK-34549 Revert "[SPARK-34549][BUILD] Upgrade aws kinesis to 1.14.0 and java sdk 1.11.844" Jun 30, 2021
@sarutak
Copy link
Member Author

sarutak commented Jun 30, 2021

Confirmed all the *Kinesis*Suite pass with the following command without newer Guava.

ENABLE_KINESIS_TESTS=1 KINESIS_TEST_ENDPOINT_URL=https://kinesis.ap-northeast-1.amazonaws.com build/sbt -Pkinesis-asl 'testOnly *Kinesis*Suite'

@HyukjinKwon
Copy link
Member

Let me merge this one first since it cause the regression, @dongjoon-hyun @viirya

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you, @sarutak and @HyukjinKwon !

cc @gengliangwang

@viirya
Copy link
Member

viirya commented Jun 30, 2021

lgtm, thanks!

@SparkQA
Copy link

SparkQA commented Jun 30, 2021

Test build #140412 has finished for PR 33145 at commit ef6f752.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak
Copy link
Member Author

sarutak commented Jun 30, 2021

Let's try to upgrade again once Guava is successfully upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants