chore(metastore-cache): add codec support #24586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24586 +/- ##
==========================================
- Coverage 69.08% 69.06% -0.02%
==========================================
Files 1906 1906
Lines 74168 74175 +7
Branches 8164 8164
==========================================
- Hits 51239 51232 -7
- Misses 20807 20821 +14
Partials 2122 2122
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
force-pushed
the
villebro/metastore-codec
branch
from
dd1cbca to
261c5fa
Compare
villebro
force-pushed
the
villebro/metastore-codec
branch
from
261c5fa to
af1ce10
Compare
dpgaspar
approved these changes
Jul 4, 2023
michael-s-molina
added
the
v3.0
eschutho
pushed a commit
that referenced
this pull request
Jul 8, 2023
eschutho
pushed a commit
that referenced
this pull request
Jul 10, 2023
eschutho
pushed a commit
that referenced
this pull request
Jul 10, 2023
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit a4880ca)
villebro
added a commit
that referenced
this pull request
Jul 28, 2023
eschutho
pushed a commit
that referenced
this pull request
Aug 4, 2023
9 tasks
|
@michael-s-molina I see that this PR is flagged for 3.0. You'll probably also want to bring in #24970 |
Thanks @eschutho. Will do. |
mistercrunch
added
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds the option to use a custom codec for serializing/deserializing values in the
SupersetMetastoreCache. In addition, the default Explore form data and Dashboard filter state cache config is changed to use the JSON key-value codec. This will not affect deployments that are using Redis or another cache. In addition, we're already emitting a warning when using it in prod, and since it will only cause a problem if a user happens to refresh their browser right after the state has last been updated, there is minimal risk that this will cause issues for users.Tests are added to ensure that the cache works as expected with both the JSON and Pickle codecs.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION