-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot expand initially hidden SQL Lab tab #26279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilykuang
approved these changes
Dec 14, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26279 +/- ##
==========================================
- Coverage 66.99% 66.99% -0.01%
==========================================
Files 1945 1945
Lines 75949 75949
Branches 8460 8460
==========================================
- Hits 50885 50884 -1
Misses 22879 22879
- Partials 2185 2186 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
added a commit
that referenced
this pull request
Dec 15, 2023
michael-s-molina
added a commit
that referenced
this pull request
Dec 18, 2023
(cherry picked from commit aa3c3c5)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit aa3c3c5)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
size/XS
v3.0
Label added by the release manager to track PRs to be included in the 3.0 branch
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
🍒 3.0.3
🍒 3.0.4
🍒 3.1.0
🍒 3.1.1
🍒 3.1.2
🍒 3.1.3
🚢 4.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug that prevented SQL Lab tabs to be expanded when they were initially hidden.
Fixes #26248
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2023-12-14.at.14.04.09.mov
Screen.Recording.2023-12-14.at.14.03.05.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION