Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding AntdThemeProvider to storybook config #29795

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jul 31, 2024

SUMMARY

People had begun to add AntdThemeProvider in various Storybook stories. This PR centralizes that in a single place.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

@rusackas rusackas changed the title adding AntdThemeProvider to storybook config feat: adding AntdThemeProvider to storybook config Jul 31, 2024
@rusackas rusackas requested a review from geido July 31, 2024 15:53
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 31, 2024
@rusackas rusackas merged commit da46ad4 into master Jul 31, 2024
34 of 35 checks passed
@rusackas rusackas deleted the AntdThemeProvider-in-sotrybook branch July 31, 2024 19:14
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants