Add get_lockup_duration to Staking trait #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/implementations/osmosis.rs
Outdated
| @@ -290,4 +296,8 @@ impl Staking<OsmosisOptions, Coin> for OsmosisSuperfluidStaking { | |||
| // Rewards are automatically distributed to stakers every epoch. | |||
| Ok(Response::new()) | |||
| } | |||
|
|
|||
| fn get_lockup_duration(&self) -> Result<CwDuration, CwDexError> { | |||
| todo!() | |||
There was a problem hiding this comment.
todo -> panics here, todo macro is only for prototyping. Should we handle with a custom message ( ContractError("lockup duration not implemented for osmosis") )?
Signed-off-by: Bobby <bobby@apollo.farm>
fix: update bindings dependency and remove use of OsmosisQuerier
Signed-off-by: Bobby <bobby@apollo.farm>
georgemc98
force-pushed
the
dev/osmosis-vault-unstake-withdraw
branch
from
69fa676 to
2880d2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.