Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add graphql-tag-swc-plugin to performance docs #11884

Merged
merged 5 commits into from
Jun 12, 2024
Merged

docs: add graphql-tag-swc-plugin to performance docs #11884

merged 5 commits into from
Jun 12, 2024

Conversation

rishabh3112
Copy link
Contributor

Closes: #11872

@rishabh3112 rishabh3112 requested a review from a team as a code owner June 10, 2024 11:03
@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a983629

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a983629

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rishabh3112 rishabh3112 changed the title docs: add grahql-tag-swc-plugin to performance docs docs: add graphql-tag-swc-plugin to performance docs Jun 10, 2024
@rishabh3112 rishabh3112 mentioned this pull request Jun 11, 2024
Closed
jerelmiller
jerelmiller reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 tiny changes I'd recommend, but otherwise looks great! Thanks so much for the addition. I'll get this in as soon as the changes are in place 🙂

jerelmiller
jerelmiller approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I'll go ahead and get this out 🙂

@jerelmiller jerelmiller merged commit 5f5326b into apollographql:main Jun 12, 2024
10 of 20 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alessbell alessbell alessbell left review comments

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding graphql-tag-swc-plugin to performance docs for apollo client
3 participants
@rishabh3112 @jerelmiller @alessbell