Add parameters from template to dialog box #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
reviewed
Apr 22, 2021
| <a | ||
| href="#" | ||
| data-apos-dialog-box-trigger="DIALOG_BOX_ID" | ||
| data-apos-dialog-box-parameters="{{ parameters | dump }}" |
There was a problem hiding this comment.
Use jsonAttribute. dump is not designed to be guaranteed safe in an attribute, I don't think.
boutell
requested changes
Apr 22, 2021
| @@ -243,20 +254,29 @@ | |||
| event.preventDefault(); | |||
|
|
|||
| var dialogId = button.dataset.aposDialogBoxTrigger; | |||
| var parameters = JSON.parse(button.dataset.aposDialogBoxParameters || null); | |||
There was a problem hiding this comment.
Hmm, JSON.parse(null) does not crash for me either, but it seems risky; how about || 'null'?
| </div> | ||
| ``` | ||
|
|
||
| This way, a widget inside the dialog box can read the added parameters and use them. |
There was a problem hiding this comment.
Provide an example of how the widget would access the parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab-dcadcx.michelin.net/pa/apostrophe-enhancements/-/issues/1054