Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Get rid of Carthage #434

Merged
merged 8 commits into from
Dec 14, 2020
Merged

refactor: Get rid of Carthage #434

merged 8 commits into from
Dec 14, 2020

Conversation

mykola-mokhnach
Copy link

I'm tired of creating workarounds for all this dependency stuff. Including these helper libs into WDA source would help us to speed up the bootstrapping process. I had to disable "Treat warnings as errors" option, since the added sources are full of warnings, but lets do everything step by step.

@KazuCocoa
Copy link
Member

👍
I'll review and test this pr tomorrow with below envs (as a note):

  • Simulators:
    • M1 mac, Xcode 12.2 and 12.3
    • Intel mac, Xcode 10, 11 and 12.
  • a real device
    • iOS 14.2 x M1 mac
    • iOS 14.2 x Intel mac (and probably iOS 13 or 12 ipod)

Run build -> check /source and video

@jlipps
Copy link
Member

jlipps commented Dec 14, 2020

👍 i can't evaluate the code changes but am a fan of the idea

@KazuCocoa
Copy link
Member

Everything worked @mykola-mokhnach
I've tested with:

M1 Mac: Xcode 12.2 and 12.3 (both simulators and a real device)
Intel Mac 10.15.7: Xcode 12.2, 12.3 and Xcode 11 (both simulators and a real device)
Intel Mac 10.14: Xcode 10.3

#433 will allow us to build this for over iOS 10

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is huge, but I tested various environments. They worked well.
I also reviewed some points like removing carthage stuff from this repository.
This also looks good to me

@KazuCocoa
Copy link
Member

This will close #432

@choli
Copy link

choli commented Mar 19, 2021

I might be late to the party, but is there a reason to not use robbiehanson/CocoaAsyncSocket as a Swift pakage? This library seems to be good maintained and swift package manager leaves out the annoying "carthaging", as this obviously was super annoying since xcode 12. Just a question :) thanks

@KazuCocoa
Copy link
Member

We still support Xcode 10.2+.

I haven't tested well, but if Swift Package manager works well from Xcode 11 and Xcode 12 without the project change, maybe we can use it after supporting only Xcode 11.

I mean once we configure Swift Package manager in Xcode 11.0, the latest Xcode 12.4 (5 beta) also works without modification in project files. (Appium/WDA does not need Carthate, so no strong motivation to use swift package manager for now though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants