-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Get rid of Carthage #434
Conversation
👍
Run build -> check |
👍 i can't evaluate the code changes but am a fan of the idea |
Everything worked @mykola-mokhnach M1 Mac: Xcode 12.2 and 12.3 (both simulators and a real device) #433 will allow us to build this for over iOS 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is huge, but I tested various environments. They worked well.
I also reviewed some points like removing carthage stuff from this repository.
This also looks good to me
This will close #432 |
I might be late to the party, but is there a reason to not use robbiehanson/CocoaAsyncSocket as a Swift pakage? This library seems to be good maintained and swift package manager leaves out the annoying "carthaging", as this obviously was super annoying since xcode 12. Just a question :) thanks |
We still support Xcode 10.2+. I haven't tested well, but if Swift Package manager works well from Xcode 11 and Xcode 12 without the project change, maybe we can use it after supporting only Xcode 11. I mean once we configure Swift Package manager in Xcode 11.0, the latest Xcode 12.4 (5 beta) also works without modification in project files. (Appium/WDA does not need Carthate, so no strong motivation to use swift package manager for now though) |
I'm tired of creating workarounds for all this dependency stuff. Including these helper libs into WDA source would help us to speed up the bootstrapping process. I had to disable "Treat warnings as errors" option, since the added sources are full of warnings, but lets do everything step by step.