ci: remove unnecessary ruby installation on Azure #559
Conversation
Scripts/build.sh
Outdated
| @@ -87,7 +87,7 @@ function xcbuild() { | |||
|
|
|||
| function fastlane_test() { | |||
| if [[ -n "$XC_DESTINATION" ]]; then | |||
| SDK="$XC_SDK" DEST="$XC_DESTINATION" SCHEME="$1" bundle exec fastlane test | |||
| SDK="$XC_SDK" DEST="$XC_DESTINATION" SCHEME="$1" fastlane test | |||
| else | |||
| SDK="$XC_SDK" SCHEME="$1" bundle exec fastlane test | |||
There was a problem hiding this comment.
should we also remove bundle exec from here?
There was a problem hiding this comment.
I noticed Azure instance already has fastalne, so we can use pre-installed one in our usage. Let me try it.
| @@ -87,7 +87,7 @@ function xcbuild() { | |||
|
|
|||
| function fastlane_test() { | |||
| if [[ -n "$XC_DESTINATION" ]]; then | |||
| SDK="$XC_SDK" DEST="$XC_DESTINATION" SCHEME="$1" bundle exec fastlane test | |||
| SDK="$XC_SDK" DEST="$XC_DESTINATION" SCHEME="$1" fastlane test | |||
There was a problem hiding this comment.
shall we check first if fastlane is present using which? This might fail if we decide to chance CI once or run it locally
There was a problem hiding this comment.
Yes, good idea. Will add it.
There was a problem hiding this comment.
Added https://github.com/appium/WebDriverAgent/pull/559/files#diff-688f25f2178d0f34696efce56d6c90f8f89fa5e88ba61efbafa9a96a652b2ceaR89-R93.
After bundle install case also works with only fastlane command.
KazuCocoa
changed the title
|
ok, it seems fastlane worked in the bundled one. This PR keeps Gemfile so that anyone can get fastlane as bundle install in this repo. |
|
What is the reason to remove the lockfile? |
Since the CI machine no longer uses it for now. It uses pre-installed one. When we move to another CI, which has no-fastlane by default, or would like to keep this dev env for our local run, lockfile may help though. |
Azure has fastlane tool, so we can use them directly.
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#tools