Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bundle:tv for tvOS #657

Merged
merged 3 commits into from
Feb 5, 2023
Merged

chore: bundle:tv for tvOS #657

merged 3 commits into from
Feb 5, 2023

Conversation

KazuCocoa
Copy link
Member

npm run bundle:tv builds WDA for tvOS

@KazuCocoa KazuCocoa changed the title chore: build:tv for tvOS chore: bundle:tv for tvOS Jan 28, 2023
@@ -13,7 +13,9 @@
"prepare": "npm run build",
"test": "mocha --exit --timeout 1m \"./test/unit/**/*-specs.js\"",
"e2e-test": "mocha --exit --timeout 10m \"./test/functional/**/*-specs.js\"",
"bundle": "node ./Scripts/build-webdriveragent.js",
"bundle": "npm run bundle:ios && npm run bundle:tv",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we run these in parallel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be...? Parallel xcodebuild raised some build errors long before, so here runs one by one. Maybe some part such as creating zip can be parallel though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the xcodebuild in parallel. Then exit 65 code was raised, so currently it would be safe to run one by one. We'll be able to optimize parallel running except for xcodebuild in the future

@KazuCocoa
Copy link
Member Author

i'll do something as another pr when I need to tune more

@KazuCocoa KazuCocoa merged commit 9d2d047 into master Feb 5, 2023
@KazuCocoa KazuCocoa deleted the tvos-build branch February 5, 2023 07:22
github-actions bot pushed a commit that referenced this pull request Feb 5, 2023
## [4.10.23](v4.10.22...v4.10.23) (2023-02-05)

### Miscellaneous Chores

* bundle:tv for tvOS ([#657](#657)) ([9d2d047](9d2d047))
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🎉 This PR is included in version 4.10.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants