-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow extension capability keys to contain dot characters #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Feb 24, 2025
src/main/java/io/appium/java_client/remote/options/W3CCapabilityKeys.java
Outdated
Show resolved
Hide resolved
@alexanderkaiser could you please sign CLA? |
valfirst
approved these changes
Feb 24, 2025
mykola-mokhnach
approved these changes
Feb 24, 2025
Hi @alexanderkaiser, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Extend the
ACCEPTED_W3C_PATTERNS
from^[\\w-]+:.*$
to^[\\w-\\.]+:.*$
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
I'm running an Appium-based test suite in a device cloud. This device cloud has some vendor specific capabilities and I have the option to provide these either with the prefix
digital.ai
or without any prefix.I used to just use the second option and the following capability statement was no big deal:
But I have the problem that the second option does not work anymore since a few weeks. The actual capabilities look like this
And when I switch to the first option by using the vendor-specific key
digital.ai
I get this:leading to the point, that the device cloud cannot find the accessKey for auth.
A
.
DOT is not allowed, but a-
DASH is. I could not find any restrictions in the spec for this behavior.