chore: remove ios uiautomation (#436)

* feat: drop iOS/uiautomation as no longer work with recent iOS versions

* update changelog

* remove uiautomation stuff

Author: KazuCocoa

CHANGELOG.md

@@ -9,6 +9,8 @@ Read `release_notes.md` for commit level details.
 ### Bug fixes
 
 ### Deprecations
+- Remove iOS/UiAutomation classes
+    - The version may work for iOS 8. XCUITest driver will be the default behavior for iOS.
 
 ## [5.8.0] - 2022-12-11
 

lib/appium_lib_core/common/base/search_context.rb

@@ -28,7 +28,6 @@ module SearchContext
           data_matcher:         '-android datamatcher', # Available in Espresso
           view_matcher:         '-android viewmatcher', # Available in Espresso
           # iOS
-          uiautomation:         '-ios uiautomation',
           predicate:            '-ios predicate string',
           class_chain:          '-ios class chain',
           # Windows with windows prefix

lib/appium_lib_core/driver.rb

@@ -23,7 +23,6 @@ module Android
     end
 
     module Ios
-      autoload :Uiautomation, 'appium_lib_core/ios'
       autoload :Xcuitest, 'appium_lib_core/ios_xcuitest'
     end
 
@@ -605,10 +604,8 @@ def extend_for(device:, automation_name:) # rubocop:disable Metrics/CyclomaticCo
           case sym_automation_name
           when :safari
             ::Appium::Logger.debug('SafariDriver for iOS')
-          when :xcuitest
+          else # XCUITest
             ::Appium::Core::Ios::Xcuitest::Bridge.for self
-          else # default and UIAutomation
-            ::Appium::Core::Ios::Uiautomation::Bridge.for self
           end
         when :mac
           case sym_automation_name

lib/appium_lib_core/ios.rb

@@ -204,15 +204,9 @@ def test_settings
 
       # @deprecated Appium::Core::TouchAction
       def test_touch_actions
-        if @@core.automation_name == :xcuitest
-          element = @@core.wait { @@driver.find_element :accessibility_id, ACTIVITY_INDICATORS }
-
-          @@driver.execute_script('mobile: tap', x: 0, y: 0, element: element.id)
-        else
-          Appium::Core::TouchAction.new(@@driver)
-                                   .press(element: @@driver.find_element(:accessibility_id, ACTIVITY_INDICATORS))
-                                   .perform
-        end
+        element = @@core.wait { @@driver.find_element :accessibility_id, ACTIVITY_INDICATORS }
+
+        @@driver.execute_script('mobile: tap', x: 0, y: 0, element: element.id)
 
         @@driver.back
       end

lib/appium_lib_core/ios/uiautomation/bridge.rb

@@ -28,23 +28,12 @@ def teardown
         save_reports(@@driver)
       end
 
-      def test_uiautomation
-        if @@core.automation_name == :xcuitest
-          assert true
-        else
-          e = @@driver.find_element :predicate, 'wdName == "Buttons"'
-          assert !e.name.nil?
-        end
-      end
-
       def test_predicate
         e = @@driver.find_element :predicate, 'wdName == "Buttons"'
         assert_equal 'Buttons', e.name
       end
 
       def test_class_chain
-        skip 'Only for XCUITest'  unless @@core.automation_name == :xcuitest
-
         e = @@driver.find_element :class_chain, "**/XCUIElementTypeWindow[$name == 'Buttons'$]"
         assert_equal 'XCUIElementTypeWindow', e.tag_name
       end

lib/appium_lib_core/ios/uiautomation/device.rb

@@ -460,7 +460,7 @@ def _android_mock_create_session_w3c_with_custom_http_client(core)
 
     # https://www.w3.org/TR/webdriver1/
     def test_search_context_in_element_class
-      assert_equal 23, ::Appium::Core::Element::FINDERS.length
+      assert_equal 22, ::Appium::Core::Element::FINDERS.length
       assert_equal({ class: 'class name',
                      class_name: 'class name',
                      css: 'css selector',                    # Defined in W3C spec
@@ -479,7 +479,6 @@ def test_search_context_in_element_class
                      viewtag: '-android viewtag',
                      data_matcher: '-android datamatcher',
                      view_matcher: '-android viewmatcher',
-                     uiautomation: '-ios uiautomation',
                      predicate: '-ios predicate string',
                      class_chain: '-ios class chain',
                      windows_uiautomation: '-windows uiautomation',

lib/appium_lib_core/ios/uiautomation/patch.rb

@@ -47,8 +47,6 @@ def test_toggle_touch_id_enrollment
           end
 
           def test_start_recording_screen
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/appium/start_recording_screen")
               .with(body: { options: { videoType: 'mjpeg', timeLimit: '180' } }.to_json)
               .to_return(headers: HEADER, status: 200, body: { value: ['a'] }.to_json)
@@ -59,8 +57,6 @@ def test_start_recording_screen
           end
 
           def test_start_recording_screen_custom
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/appium/start_recording_screen")
               .with(body: { options: {
                 videoType: 'libx264', timeLimit: '60',
@@ -76,8 +72,6 @@ def test_start_recording_screen_custom
           end
 
           def test_stop_recording_screen_default
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/appium/stop_recording_screen")
               .with(body: {}.to_json)
               .to_return(headers: HEADER, status: 200, body: { value: ['a'] }.to_json)
@@ -88,8 +82,6 @@ def test_stop_recording_screen_default
           end
 
           def test_stop_recording_screen_custom
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/appium/stop_recording_screen")
               .with(body: { options:
                                 { remotePath: 'https://example.com', user: 'user name', pass: 'pass', method: 'PUT' } }.to_json)
@@ -101,8 +93,6 @@ def test_stop_recording_screen_custom
           end
 
           def test_start_recording_screen_additional_options
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/appium/start_recording_screen")
               .with(body: { options: {
                 remotePath: 'https://example.com', method: 'PUT',
@@ -121,8 +111,6 @@ def test_start_recording_screen_additional_options
           end
 
           def test_get_battery_info
-            skip 'Only XCUITest supports' unless @core.automation_name == :xcuitest
-
             stub_request(:post, "#{SESSION}/execute/sync")
               .with(body: { script: 'mobile: batteryInfo', args: [{}] }.to_json)
               .to_return(headers: HEADER, status: 200, body: { value: { state: 1, level: 0.5 } }.to_json)
@@ -145,15 +133,9 @@ def test_method_missing
           end
 
           def test_background_app
-            if @core.automation_name == :xcuitest
-              stub_request(:post, "#{SESSION}/appium/app/background")
-                .with(body: { seconds: { timeout: 0 } }.to_json)
-                .to_return(headers: HEADER, status: 200, body: { value: '' }.to_json)
-            else
-              stub_request(:post, "#{SESSION}/appium/app/background")
-                .with(body: { seconds: 0 }.to_json)
-                .to_return(headers: HEADER, status: 200, body: { value: '' }.to_json)
-            end
+            stub_request(:post, "#{SESSION}/appium/app/background")
+              .with(body: { seconds: { timeout: 0 } }.to_json)
+              .to_return(headers: HEADER, status: 200, body: { value: '' }.to_json)
 
             @driver.background_app 0