Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix method_missing not having the correct signature #184

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

fruwe
Copy link
Contributor

@fruwe fruwe commented Jan 22, 2019

While I was trying to run to_yaml on a hash containing an appium element, an error was raised,
since the class is missing a encode_with method.

Since the method_missing method itself has the wrong signature, it failed actually with wrong number of arguments.

This PR fixes the signature of method_missing inside patch.rb

FYI I ended up adding encode_with as well:

def encode_with coder
  coder['name'] = name
end

@jsf-clabot
Copy link

jsf-clabot commented Jan 22, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. thanks!

@KazuCocoa KazuCocoa merged commit 3f77722 into appium:master Jan 22, 2019
@KazuCocoa
Copy link
Member

@fruwe
Copy link
Contributor Author

fruwe commented Jan 23, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants