apply intern #52
Merged
apply intern #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rjaros87
suggested changes
Jan 19, 2018
lib/appium_lib_core/driver.rb
Outdated
| @@ -458,7 +458,8 @@ def set_automation_name | |||
| # @private | |||
| def set_automation_name_if_nil | |||
| return unless @automation_name.nil? | |||
| @automation_name = @driver.capabilities['automationName'] | |||
| automation_name = @driver.capabilities['automationName'] | |||
| @automation_name = automation_name.nil? ? automation_name : automation_name.intern | |||
There was a problem hiding this comment.
.nil? maybe .is_a? Symbol
in 460 you checked that.
There was a problem hiding this comment.
Because we can set a blank automationName and then @driver.capabilities['automationName'] will be nil.
KazuCocoa
force-pushed
the
fix_automation_name
branch
from
21b7323 to
c643f8c
Compare
KazuCocoa
force-pushed
the
fix_automation_name
branch
from
c643f8c to
9e33336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing symbol set in set_automation_name_if_nil method #50