Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up and organize project; partially resolves #40. #48

Closed
wants to merge 1 commit into from
Closed

Clean-up and organize project; partially resolves #40. #48

wants to merge 1 commit into from

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Sep 3, 2018

GitHub issue(s): #40

What does this Pull Request do?

  • Moves Docs -> doc
  • Moves tests -> src/tests
  • Moves headers -> src/headers
  • Moves src/*.c -> src/main
  • Moves unity -> vendor/unity
  • Updates Doxygen config
  • Update Doxygen generated docs
  • Update README
  • Update all src files that need to be updated to reflect re-org
  • Update Makefile so project builds

How should this be tested?

It should build, test should pass, and it should still run as it currently does. I've built, and test it with auk locally, and everything appears to be working fine.

Additional Notes:

We need to create a ticket for automake and push a branch for that with the existing configure.scan. I'll take care of that later today, or later this week.

@ruebot
Clean-up and organize project; partially resolves #40.
c23f409 
- Moves Docs -> doc
- Moves tests -> src/tests
- Moves headers -> src/headers
- Moves src/*.c -> src/main
- Moves unity -> vendor/unity
- Updates Doxygen config
- Update Doxygen generated docs
- Update README
- Update all src files that need to be updated to reflect re-org
- Update Makefile so project builds
@ruebot
Copy link
Member Author

ruebot commented Sep 3, 2018

I believe #40 will be fully resolved by merging this, and creating the new automake ticket and pushing the branch for it.

ianmilligan1
ianmilligan1 approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally and tested some outputs in AUK - all good on my end. 👍

@ruebot
Copy link
Member Author

ruebot commented Sep 3, 2018

autoconf ticket #49, and branch is here.

Merging this should now fully resolve #40.

@ruebot
Copy link
Member Author

ruebot commented Sep 3, 2018

I did some subtle changes to the Makefile, cleaned up whitespace, and squashed & rebased. I'm going to close this and push up a new PR since GitHub isn't picking it up again. 🤷‍♂️

@ruebot ruebot closed this Sep 3, 2018
@ruebot ruebot deleted the issue-40 branch September 3, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmilligan1 ianmilligan1 ianmilligan1 approved these changes

@greebie greebie Awaiting requested review from greebie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruebot @ianmilligan1