fix(plugin): decouple state update from the LS #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enhance the reliability of Arduino IDE extensions, the update process for `ArduinoState` has been modified to ensure independence from the language server's availability. This change addresses issues caused by `compileSummary` being `undefined` due to potential startup failures of the Arduino Language Server, as noted in dankeboy36/esp-exception-decoder#28 (comment). The `compile` command now resolves with a `CompileSummary` rather than `void`, facilitating a more reliable way for extensions to access necessary data. Furthermore, the command has been adjusted to allow resolution with `undefined` when the compiled data is partial. By transitioning to direct usage of the resolved compile value for state updates, the reliance on executed commands for extensions is eliminated. This update also moves the VSIX command execution to the frontend without altering existing IDE behavior. Closes arduino#2642 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
giacomocusinato
requested changes
Feb 27, 2025
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
+ event emitter dispatches the new state. Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
I liked your solution (b11bde1) and cherry-picked it here. Let me know if it's OK for you. |
revert of arduino@b11bde1 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
|
Thank you for reviewing the PR multiple times. If it looks good, can you please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To enhance the reliability of Arduino IDE extensions, the update process for
ArduinoStatehas been modified to ensure independence from the language server's availability. This change addresses issues caused bycompileSummarybeingundefineddue to potential startup failures of the Arduino Language Server, as noted in dankeboy36/esp-exception-decoder#28 (comment).Change description
The
compilecommand now resolves with aCompileSummaryrather thanvoid, facilitating a more reliable way for extensions to access necessary data. Furthermore, the command has been adjusted to allow resolution withundefinedwhen the compiled data is partial.Other information
By transitioning to direct usage of the resolved compile value for state updates, the reliance on executed commands for extensions is eliminated. This update also moves the VSIX command execution to the frontend without altering existing IDE behavior.
Closes #2642
Reviewer checklist