Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switched to stable toolchain for clippy and fmt, fixed lints #531

Merged
merged 2 commits into from
Oct 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
- uses: dtolnay/rust-toolchain@beta
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy
- name: Clippy (argmin-math)
Expand All @@ -161,7 +161,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
- uses: dtolnay/rust-toolchain@beta
- uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt
- run: cargo fmt --all -- --check
Expand Down
2 changes: 1 addition & 1 deletion crates/argmin-observer-slog/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ impl SlogLogger {

struct SlogKV<'a>(&'a KV);

impl<'a> slog::KV for SlogKV<'a> {
impl slog::KV for SlogKV<'_> {
fn serialize(&self, _record: &Record, serializer: &mut dyn Serializer) -> slog::Result {
for idx in self.0.kv.iter() {
serializer.emit_str(Key::from(idx.0.to_string()), &idx.1.to_string())?;
Expand Down
2 changes: 1 addition & 1 deletion crates/argmin/src/solver/newton/newton_cg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ impl<'a, P, H> CGSubProblem<'a, P, H> {
}
}

impl<'a, P, H> Operator for CGSubProblem<'a, P, H>
impl<P, H> Operator for CGSubProblem<'_, P, H>
where
H: ArgminDot<P, P>,
{
Expand Down
3 changes: 3 additions & 0 deletions crates/finitediff/src/array/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

// Some types just are complex
#![allow(clippy::type_complexity)]

pub mod diff;
pub mod hessian;
pub mod jacobian;
Expand Down
3 changes: 3 additions & 0 deletions crates/finitediff/src/vec/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

// Some types just are complex
#![allow(clippy::type_complexity)]

pub mod diff;
pub mod hessian;
pub mod jacobian;
Expand Down
Loading