Support Jupyter saving to S3 #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eric-anderson
commented
Oct 1, 2024
eric-anderson
commented
- Add support configured by setting the JUPYTER_S3_BUCKET and JUPTYER_S3_PREFIX variables
- Add support for resetting the jupyter configuration via JUPYTER_CONFIG_RESET (can also delete the file)
- Fix bug in startup script that could end up racing with the jupyter log file being written
- Switch to jupyter lab by default
- Add cache to gitignore (it's generated by a notebook)
- Add package-mode=false to pyproject -- I'm on python3.12 and getting warnings
- Add pip as an explicit dependencies -- I'm on python3.12 and it's not installed by default leading to mypy errors installing type info dependencies.
* Add support configured by setting the JUPYTER_S3_BUCKET and JUPTYER_S3_PREFIX variables * Add support for resetting the jupyter configuration via JUPYTER_CONFIG_RESET (can also delete the file) * Fix bug in startup script that could end up racing with the jupyter log file being written * Switch to jupyter lab by default * Add cache to gitignore (it's generated by a notebook) * Add package-mode=false to pyproject -- I'm on python3.12 and getting warnings * Add pip as an explicit dependencies -- I'm on python3.12 and it's not installed by default leading to mypy errors installing type info dependencies.
baitsguy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.