Allow for returning query traces on cached query executions. #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baitsguy
reviewed
Oct 21, 2024
baitsguy
reviewed
Oct 21, 2024
| assert isinstance(result, str) | ||
| assert len(result) > 0 | ||
| result = client.run_plan(plan, codegen_mode=codegen_mode) | ||
| assert isinstance(result.result, str) |
There was a problem hiding this comment.
seems like this is failing
There was a problem hiding this comment.
It was passing for me but the test is still flaky
baitsguy
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #949 with a better implementation that allows the results of cached query executions to return traces. This is done by removing the concept of a separate 'trace_dir' and returning the location of the cache results for each node in the query plan. This way we can have our cache and traces too :-)
The PR also makes a few other small changes:
SycamoreQueryResulttype which includes the query ID, query plan, query result, and the location of the query traces..materialize()so we can use the same logic for reading the traces back everywhere..rerankwas broken. This test now passes!