feat(string): String#replaceAllを追加 #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for js-primer ready! Built with commit 6264f8b |
azu
commented
May 9, 2021
| @@ -1035,15 +1056,15 @@ const 置換した結果の文字列 = 文字列.replace(/(パターン)/, (all, | |||
|
|
|||
| 例として、`2017-03-01`を`2017年03月01日`に置換する処理を書いてみましょう。 | |||
|
|
|||
| `/(\d{4})-(\d{2})-(\d{2})/`という正規表現が`"2017-03-01"`という文字列にマッチします。 | |||
| `/(\d{4})-(\d{2})-(\d{2})/g`という正規表現が`"2017-03-01"`という文字列にマッチします。 | |||
There was a problem hiding this comment.
このサンプル、微妙にgがある方が自然になっているので、
もうちょっと別の例にするのが良いかもしれない。
source/basic/string/README.md
Outdated
|
|
||
| `replace`メソッドの第二引数にはコールバック関数を渡せます。 | ||
| `String#replace`と`g`フラグ付きの正規表現を使った場合との違いとして、 | ||
| `String#replaceAll`メソッドでは、正規表現を使わずにすべてを置換できます。 |
There was a problem hiding this comment.
要点はこれなので、細かいところはちょっと解説していない。
正規表現も渡せるとか第2引数とか、は基本replaceと同じなので。
azu
commented
May 9, 2021
source/basic/string/README.md
Outdated
|
|
||
| `replace`メソッドの第二引数にはコールバック関数を渡せます。 | ||
| `String#replace`と`g`フラグ付きの正規表現を使った場合との違いとして、 | ||
| `String#replaceAll`メソッドでは、正規表現を使わずに文字列を使ってすべてを置換できます。 |
There was a problem hiding this comment.
細かい言い回しが気になるけど、あんまり最適なのが思いつかないな。
There was a problem hiding this comment.
すべてを置換できます。
繰り返し置換 という表現も考えたけど、replaceAllなのですべてとか全部とかソッチのほうが合う感じがした
azu
commented
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対象ページ
変更点
fix #1310