Deprecate asdf.asdf and AsdfFile.resolve_and_inline and minor cleanup
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
changed the title
asdf.asdf and slight cleanupasdf.asdf and minor cleanup
braingram
changed the title
asdf.asdf and minor cleanupasdf.asdf and AsdfFile.resolve_and_inline and minor cleanup
braingram
force-pushed
the
cleanup_asdf
branch
from
19487b3 to
b34395a
Compare
braingram
force-pushed
the
cleanup_asdf
branch
from
bed9fcc to
448067a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is work towards cleaning up the asdf api focusing on
asdf.asdf.This PR deprecates
asdf.asdf. The two public portions of this moduleAsdfFileandopen_asdfare already exposed at the more convenient top levelasdf(asAsdfFileandopen) so this PR movesasdf.asdftoasdf._asdfand adds a deprecation warning on import or use ofasdf.asdf.Additionally, this PR deprecates
AsdfFile.resolve_and_inline(which can be replaced withAsdfFile.resolve_referencesand providingall_array_storage='inline'towrite_to/update).Finally, this PR adds a prefix to
asdf.asdf.get_asdf_library_infoto make it more explicit that this is a private method.A few warnings can be seen in the weldx downstream job as this PR adds an
AsdfDeprecationWarningfor theasdf.asdf.SerializationContextmove in #1573.Checklist: