ci: Build-test documentation with warnings disallowed, and fix broken links #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
build-test-docs
branch
from
39a24e1 to
d198ca1
Compare
MarijnS95
commented
Jan 19, 2022
MarijnS95
commented
Jan 19, 2022
Ralith
approved these changes
Jan 20, 2022
MarijnS95
force-pushed
the
build-test-docs
branch
from
d198ca1 to
595f93a
Compare
MarijnS95
force-pushed
the
build-test-docs
branch
from
595f93a to
d47f6c6
Compare
MarijnS95
changed the title
Ralith
approved these changes
Jan 22, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 24, 2022
Suggestion from [#559]. [#559]: #559 (comment)
MarijnS95
added a commit
that referenced
this pull request
Jan 24, 2022
Suggestion from [#559]. [#559]: #559 (comment)
Ralith
pushed a commit
that referenced
this pull request
Jan 24, 2022
Suggestion from [#559]. [#559]: #559 (comment)
MarijnS95
added a commit
that referenced
this pull request
Aug 11, 2022
The report at rust-lang/rust#93205 was closed as it has presumably been fixed in rust-lang/rust#93805 which has long trickled down into stable releases, and I cannot reproduce the issue on `1.62.1` anymore (latest stable as of writing) 🎉 This workaround was originally added in #559.
Ralith
pushed a commit
that referenced
this pull request
Aug 11, 2022
The report at rust-lang/rust#93205 was closed as it has presumably been fixed in rust-lang/rust#93805 which has long trickled down into stable releases, and I cannot reproduce the issue on `1.62.1` anymore (latest stable as of writing) 🎉 This workaround was originally added in #559.
MarijnS95
added a commit
that referenced
this pull request
Aug 11, 2022
The report at rust-lang/rust#93205 was closed as it has presumably been fixed in rust-lang/rust#93805 which has long trickled down into stable releases, and I cannot reproduce the issue on `1.62.1` anymore (latest stable as of writing) 🎉 This workaround was originally added in #559.
MarijnS95
added a commit
that referenced
this pull request
Aug 12, 2022
The report at rust-lang/rust#93205 was closed as it has presumably been fixed in rust-lang/rust#93805 which has long trickled down into stable releases, and I cannot reproduce the issue on `1.62.1` anymore (latest stable as of writing) 🎉 This workaround was originally added in #559.
MarijnS95
added a commit
that referenced
this pull request
Sep 5, 2022
The report at rust-lang/rust#93205 was closed as it has presumably been fixed in rust-lang/rust#93805 which has long trickled down into stable releases, and I cannot reproduce the issue on `1.62.1` anymore (latest stable as of writing) 🎉 This workaround was originally added in #559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pretty certain our documentation was at least build-tested since that's generally one of the first things I check/PR on the crates I touch... Supposedly not here. It allowed some broken links to slip in, most recently in #530 and #537 where I wrongly assumed the CI was having my back.
Let's make sure it fails now before pushing the necessary fixes.CI is properly working and finding+disallowing issues: https://github.com/MaikKlein/ash/runs/4865846622?check_suite_focus=true