changelog: Document removal of query_count parameter from get_query_pool_results()
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_pool_results()` Commit c66db26 ("device: Replace `query_count` parameter in `get_query_pool_results` with `data.len()` (#644)") removed this parameter in favour of using `data.len()` to make it more obvious to use an appropriate element type that matches the kind of request (see also #639) so that the stride is filled in correctly, but it was not mentioned in the changelog yet.
Ralith
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c66db26 ("device: Replace
query_countparameter inget_query_pool_resultswithdata.len()(#644)") removed this parameter in favour of usingdata.len()to make it more obvious to use an appropriate element type that matches the kind of request (see also #639) so that the stride is filled in correctly, but it was not mentioned in the changelog yet.