book: make sure that the ads are actually readable #146
Conversation
book/update-theme.py
Outdated
| INDEX_HBS_HEADERS = { | ||
| "user-agent": "Update index.hbs for +https://github.com/rinja-rs/rinja", | ||
| } | ||
|
|
||
| ETHICALADS_THEME = r''' | ||
| <style> |
There was a problem hiding this comment.
Don't we have a style file or something? It's pretty bad for loading speed to keep the style in a style node.
There was a problem hiding this comment.
I append the content to a css file now during readthedocs' build process. More difficult to test now, but it should be sane.
book/update-theme.py
Outdated
| ETHICALADS_THEME = r''' | ||
| <style> | ||
| .ethical-sidebar { | ||
| margin-left: auto; } |
There was a problem hiding this comment.
Also what happened with the indent here. XD
There was a problem hiding this comment.
I simply kept the default of scss. :)
There was a problem hiding this comment.
Well, please fix it. :p
| @@ -0,0 +1 @@ | |||
| .ethical-sidebar{margin-left:auto}.ethical-sidebar .ea-content{background:var(--bg) !important;color:var(--fg) !important}.ethical-sidebar .ea-content a:is(:link, :visited){color:var(--fg) !important}.ethical-sidebar .ea-content a:is(:hover, :active, :focus){color:var(--sidebar-active) !important}.ethical-sidebar .ea-content strong{color:var(--sidebar-active) !important}.ethical-sidebar .ea-callout a:is(:link, :visited){color:var(--sidebar-non-existant) !important}.ethical-sidebar .ea-callout a:is(:hover, :active, :focus){color:var(--sidebar-fg) !important} | |||
There was a problem hiding this comment.
I will close my eyes and try to forget about this. 🤣
|
Thanks! |
|
Hm, I did not not have the gray background in my local tests. It's quite obtrusive, but well, it's an ad after all? |
We are using a free service, after all.