Make JSON prettifying optional #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an optional argument to the `|tojson` filter, which controls if the serialized JSON data gets prettified or not. The arguments works the same as flask's [`|tojson`][flask] filter, which passes the argument to python's [`json.dumps()`][python]: * Omitting the argument, providing a negative integer, or `None`, then compact JSON data is generated. * Providing a non-negative integer, then this amount of ASCII spaces is used to indent the data. (Capped to 16 characters.) * Providing a string, then this string is used as prefix. I attempts are made to ensure that the prefix actually consists of whitespaces, because chances are, that if you provide e.g. `&nsbp;`, then you are doing it intentionally. This is a breaking change, because it changes the default behavior to not prettify the data. This is done intentionally, because this is how it works in flask. [flask]: https://jinja.palletsprojects.com/en/3.1.x/templates/#jinja-filters.tojson [python]: https://docs.python.org/3/library/json.html#json.dump
rinja_derive/src/generator.rs
Outdated
| buf.write(CRATE); | ||
| buf.write("::filters::json("); | ||
| self._visit_args(ctx, buf, args)?; | ||
| match args.len() { | ||
| 1 => buf.write(", ()"), |
There was a problem hiding this comment.
Instead of adding a trait to handle integer/void, why not write a specialized json filter called json_empty?
Second question: why not forcing the type of indent to be a usize so we don't have to handle types and other things? I find it a bit strange to allow users to pass a negative number of even None as arguments.
GuillaumeGomez
previously approved these changes
Jun 26, 2024
|
Looks much simpler now, thanks! Please feel free to merge once CI pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional argument to the
|tojsonfilter, which controls if the serialized JSON data gets prettified or not. The arguments works the same as flask's|tojsonfilter, which passes the argument to python'sjson.dumps():None, then compact JSON data is generated.&nsbp;, then you are doing it intentionally.This is a breaking change, because it changes the default behavior to not prettify the data. This is done intentionally, because this is how it works in flask.