-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tags & retries tests since they're not applicable to most projects #1146
Conversation
I'm also in favor of this as its an opinionated style piece that is non obvious and not "generally" applicable. Maybe just comment them out and allow people to see what the tests look like and do what they will vs full deletion though ? |
I'd rather explain that in docs than having commented code, for example under https://docs.astronomer.io/astro/test-and-troubleshoot-locally#run-tests-with-pytest or https://docs.astronomer.io/astro/cli/astro-dev-pytest. |
Should we open a matching issue with our docs page ? |
@dylanbstorey @BasPH has a docs issues been opened yet? |
A general issue was opened on this subject, not 100% sure where its at though. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 108 108
Lines 11199 11199
=======================================
Hits 9828 9828
Misses 809 809
Partials 562 562 ☔ View full report in Codecov by Sentry. |
@BasPH Is this good to merge? |
I've written a similar issue where we don't delete the pytest but we can skip them using a variable. The PyTest is helpful and from a reliability perspective helps customers with DAG integrity, but it should be configurable. Issue #1398 |
Removing the pytest cases testing for DAG tags & retries, following discussion in https://astronomer.slack.com/archives/CL44PA4DB/p1680001384869019.
Most customers don't have tags & retries configured on all DAGs so I don't think we should enforce that via tests.
Description
🎟 Issue(s)
🧪 Functional Testing
Tested change by doing a fresh
astro dev init
and runningastro dev pytest
successfully.📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft