-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitoring DAG only in non-hosted orgs #1256
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 87.17% 87.64% +0.46%
==========================================
Files 114 110 -4
Lines 13369 12574 -795
==========================================
- Hits 11655 11021 -634
+ Misses 1025 903 -122
+ Partials 689 650 -39
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One q
6a109b3
to
6d49e15
Compare
@kushalmalani @ianbuss please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit around the conditional function determining if the monitoring dag is sent. Since the ultimate aim is to remove the monitoring DAG even for Hybrid it might be nice to have this logic in one function to make it easy to change. Otherwise it looks great.
Description
We want to remove the monitoring DAG for hosted clusters, hence we are only adding the monitoring DAG if the org is not a hosted org, the deployment type is not hosted dedicated, and not hosted shared.
🎟 Issue(s)
Related https://github.com/astronomer/laminar/issues/360
Depends on https://github.com/astronomer/astro/pull/14203
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft