Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring DAG only in non-hosted orgs #1256

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

feluelle
Copy link
Member

@feluelle feluelle commented Jun 14, 2023

Description

Describe the purpose of this pull request.

We want to remove the monitoring DAG for hosted clusters, hence we are only adding the monitoring DAG if the org is not a hosted org, the deployment type is not hosted dedicated, and not hosted shared.

🎟 Issue(s)

Related https://github.com/astronomer/laminar/issues/360

Depends on https://github.com/astronomer/astro/pull/14203

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.46% 🎉

Comparison is base (4568592) 87.17% compared to head (158dc4e) 87.64%.

❗ Current head 158dc4e differs from pull request most recent head 67c4792. Consider uploading reports for the commit 67c4792 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1256      +/-   ##
==========================================
+ Coverage   87.17%   87.64%   +0.46%     
==========================================
  Files         114      110       -4     
  Lines       13369    12574     -795     
==========================================
- Hits        11655    11021     -634     
+ Misses       1025      903     -122     
+ Partials      689      650      -39     
Files Changed Coverage Δ
cloud/deploy/deploy.go 71.42% <84.61%> (+0.69%) ⬆️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ianbuss ianbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One q

@feluelle feluelle marked this pull request as ready for review June 16, 2023 10:50
@feluelle feluelle force-pushed the feature/disable-monitoring-dag-hosted-org branch from 6a109b3 to 6d49e15 Compare June 19, 2023 09:24
@feluelle feluelle requested a review from ianbuss June 19, 2023 09:27
@feluelle
Copy link
Member Author

@kushalmalani @ianbuss please take another look

Copy link

@ianbuss ianbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit around the conditional function determining if the monitoring dag is sent. Since the ultimate aim is to remove the monitoring DAG even for Hybrid it might be nice to have this logic in one function to make it easy to change. Otherwise it looks great.

@feluelle feluelle marked this pull request as draft June 20, 2023 17:18
@feluelle feluelle marked this pull request as ready for review July 19, 2023 11:23
@neel-astro neel-astro merged commit 5d2704b into main Jul 25, 2023
@neel-astro neel-astro deleted the feature/disable-monitoring-dag-hosted-org branch July 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants