Fix concurrency check for hosted deployments #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 87.53% 87.52% -0.02%
==========================================
Files 110 110
Lines 13020 13057 +37
==========================================
+ Hits 11397 11428 +31
- Misses 949 952 +3
- Partials 674 677 +3
☔ View full report in Codecov by Sentry. |
neel-astro
approved these changes
Jun 23, 2023
| @@ -184,10 +184,12 @@ func CreateOrUpdate(inputFile, action string, client astro.Client, coreClient as | |||
| // It returns an error if getting default options fail. | |||
| // It returns an error if worker-queue options are not valid. | |||
| // It returns an error if node pool id could not be found for the worker type. | |||
| func getCreateOrUpdateInput(deploymentFromFile *inspect.FormattedDeployment, clusterID, workspaceID, action string, existingDeployment *astro.Deployment, nodePools []astrocore.NodePool, client astro.Client) (astro.CreateDeploymentInput, astro.UpdateDeploymentInput, error) { | |||
| func getCreateOrUpdateInput(deploymentFromFile *inspect.FormattedDeployment, clusterID, workspaceID, action string, existingDeployment *astro.Deployment, nodePools []astrocore.NodePool, client astro.Client) (astro.CreateDeploymentInput, astro.UpdateDeploymentInput, error) { //nolint | |||
There was a problem hiding this comment.
nit: I think at some point we might have to move to using a struct instead of accepting such a large number of inputs. Also might have look at breaking down such large functions, since we have already put linting exception at few places
There was a problem hiding this comment.
I agree. This has been on my mind too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix concurrency check for hosted deployments
🎟 Issue(s)
Related #1267
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft