Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment status #1284

Merged
merged 6 commits into from
Jun 27, 2023
Merged

Fix deployment status #1284

merged 6 commits into from
Jun 27, 2023

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jun 26, 2023

Description

Describe the purpose of this pull request.

Fix Deployment Status

🎟 Issue(s)

Related #1084 #1102 #1085 #1189

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Inspect
Screenshot 2023-06-26 at 16 14 25

Deployment Wait
Screenshot 2023-06-26 at 16 40 11

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 90.38% and project coverage change: -0.01 ⚠️

Comparison is base (4e14725) 87.53% compared to head (206c3a4) 87.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
- Coverage   87.53%   87.52%   -0.01%     
==========================================
  Files         110      110              
  Lines       13068    13087      +19     
==========================================
+ Hits        11439    11455      +16     
- Misses        952      955       +3     
  Partials      677      677              
Impacted Files Coverage Δ
cloud/deployment/inspect/inspect.go 86.60% <58.33%> (-1.09%) ⬇️
cloud/deployment/deployment.go 91.39% <100.00%> (+0.19%) ⬆️
cloud/deployment/fromfile/fromfile.go 97.72% <100.00%> (ø)
cloud/deployment/workerqueue/workerqueue.go 98.27% <100.00%> (ø)
cloud/organization/organization.go 79.67% <100.00%> (ø)
cmd/cloud/deployment_inspect.go 100.00% <100.00%> (ø)
cmd/cloud/deployment_objects.go 85.24% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani marked this pull request as ready for review June 26, 2023 22:59
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from a minor nit

@kushalmalani kushalmalani requested a review from neel-astro June 27, 2023 14:50
@kushalmalani kushalmalani merged commit f023de1 into main Jun 27, 2023
@kushalmalani kushalmalani deleted the deployment-status-fix branch June 27, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants