Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for no deployments in a workspace #1292

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented Jul 5, 2023

Description

Describe the purpose of this pull request.

Fix for no deployments in a workspace. Display proper error messaging.

🎟 Issue(s)

Related #1283

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

Screenshot 2023-07-04 at 17 29 47
Screenshot 2023-07-04 at 17 34 28

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@kushalmalani kushalmalani requested a review from neel-astro as a code owner July 5, 2023 00:45
@kushalmalani kushalmalani self-assigned this Jul 5, 2023
@kushalmalani kushalmalani requested a review from sunkickr as a code owner July 5, 2023 00:45
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 94.11% and no project coverage change.

Comparison is base (4fbffff) 87.31% compared to head (c5e2cb0) 87.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files         113      113           
  Lines       13255    13264    +9     
=======================================
+ Hits        11573    11582    +9     
  Misses        992      992           
  Partials      690      690           
Impacted Files Coverage Δ
cloud/deployment/inspect/inspect.go 86.79% <80.00%> (+0.18%) ⬆️
cloud/deployment/workerqueue/workerqueue.go 98.30% <100.00%> (+0.02%) ⬆️
cmd/cloud/deployment_workerqueue.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kushalmalani kushalmalani merged commit 09f02c3 into main Jul 5, 2023
@kushalmalani kushalmalani deleted the fix-no-deployments branch July 5, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants