Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mockery version in Makefile #1319

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Pin mockery version in Makefile #1319

merged 2 commits into from
Jul 20, 2023

Conversation

neel-astro
Copy link
Contributor

@neel-astro neel-astro commented Jul 20, 2023

Description

Changes:

  • Pin the mockery version in Makefile, so that every time anyone generates mocks, they will be generated from the same mockery version, so as to avoid going back and forth on mock versions unnecessarily.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5b56ae2) 87.16% compared to head (a19d95e) 87.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         114      114           
  Lines       13351    13351           
=======================================
  Hits        11637    11637           
  Misses       1025     1025           
  Partials      689      689           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@neel-astro neel-astro changed the title Fix the mockery version in Makefile Pin mockery version in Makefile Jul 20, 2023
@neel-astro neel-astro merged commit 3ef8acd into main Jul 20, 2023
@neel-astro neel-astro deleted the fix-mockery branch July 20, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants