Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default deployment url #1378

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Update default deployment url #1378

merged 1 commit into from
Sep 6, 2023

Conversation

ryanahamilton
Copy link
Member

@ryanahamilton ryanahamilton commented Sep 5, 2023

Description

We recently updated the default URL of a Deployment without modifying the links to the old page in the CLI. We've added a redirect for the old links in the UI that we'll keep around until we no longer support the CLI version with the old links.

🎟 Issue(s)

Related #1377

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (dd5ba95) 86.85% compared to head (c1b6df5) 86.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
- Coverage   86.85%   86.84%   -0.01%     
==========================================
  Files         114      114              
  Lines       13904    13904              
==========================================
- Hits        12076    12075       -1     
- Misses       1091     1092       +1     
  Partials      737      737              
Files Changed Coverage Δ
cloud/deployment/deployment.go 91.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanahamilton ryanahamilton marked this pull request as ready for review September 6, 2023 16:17
@kushalmalani kushalmalani merged commit 5a0d9e3 into main Sep 6, 2023
@kushalmalani kushalmalani deleted the update_deployment_url branch September 6, 2023 16:19
kushalmalani pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants