Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime validation on deployment create #1418

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Conversation

sunkickr
Copy link
Contributor

Description

Fix runtime validation on deployment create so that user can create deployments with deprecated runtime versions that are currently being used by their organization

🎟 Issue(s)

🧪 Functional Testing

tested locally

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9c7beba) 86.95% compared to head (8ddfd75) 86.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   86.95%   86.94%   -0.01%     
==========================================
  Files         115      115              
  Lines       14033    14044      +11     
==========================================
+ Hits        12202    12211       +9     
- Misses       1092     1093       +1     
- Partials      739      740       +1     
Files Coverage Δ
astro-client/astro.go 100.00% <100.00%> (ø)
cloud/deployment/deployment.go 91.10% <66.66%> (-0.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit c6df2aa into main Oct 24, 2023
@sunkickr sunkickr deleted the fix-deployment-create branch October 24, 2023 16:03
kushalmalani pushed a commit that referenced this pull request Oct 31, 2023
* fix runtime validation

* fix runtime validation

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix spelling error

* fix test

* fix test

* fix test

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants