Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use flags for retrieving env connections #1423

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jeremybeard
Copy link
Contributor

Description

This changes the retrieval of environment connections during astro dev start and astro dev restart to not attempt to use the context workspace when the --workspace-id or --deployment-id flags are not set. This makes the retrieval of connections more explicit, reducing unexpected behavior. With this change the commands run with the --workspace-id or --deployment-id flag set will fail if the connections cannot be retrieved, and will automatically authenticate so that tokens can be refreshed.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c6df2aa) 86.93% compared to head (4a776b0) 86.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   86.93%   86.92%   -0.01%     
==========================================
  Files         115      115              
  Lines       14045    14055      +10     
==========================================
+ Hits        12210    12218       +8     
- Misses       1094     1095       +1     
- Partials      741      742       +1     
Files Coverage Δ
cmd/cloud/setup.go 57.39% <100.00%> (+0.75%) ⬆️
cloud/environment/environment.go 88.88% <81.81%> (ø)
cmd/airflow.go 87.64% <60.00%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr sunkickr merged commit 58c514d into main Oct 30, 2023
@sunkickr sunkickr deleted the env-conns-require-explicit-workspace branch October 30, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants