Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup typos and messaging for dev parse/pytest command #1793

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Cleanup typos and messaging for dev parse/pytest command #1793

merged 1 commit into from
Jan 31, 2025

Conversation

schnie
Copy link
Member

@schnie schnie commented Jan 30, 2025 •
edited
Loading

Description

This is just a small cosmetic PR to clean up some output on astro dev parse and astro dev pytest.

🧪 Functional Testing

Run the commands locally. The changes are purely cosmetic.

📸 Screenshots

astro dev parse

Screenshot 2025-01-30 at 3 13 36 PM

astro dev pytest

Screenshot 2025-01-30 at 3 14 13 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@schnie schnie force-pushed the cleanup-test-output branch from 9e8eefd to 9e85a7f Compare January 30, 2025 20:16
@schnie schnie marked this pull request as ready for review January 30, 2025 20:17
jeremybeard
jeremybeard approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@jeremybeard jeremybeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@schnie schnie merged commit 1845d29 into main Jan 31, 2025
3 of 4 checks passed
@schnie schnie deleted the cleanup-test-output branch January 31, 2025 15:09
BasPH pushed a commit that referenced this pull request Feb 20, 2025
@schnie @BasPH
Cleanup typos and messaging for dev parse/pytest command (#1793)
606e7c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremybeard jeremybeard jeremybeard approved these changes

@neel-astro neel-astro Awaiting requested review from neel-astro neel-astro is a code owner

@kushalmalani kushalmalani Awaiting requested review from kushalmalani kushalmalani is a code owner

@lzdanski lzdanski Awaiting requested review from lzdanski lzdanski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schnie @jeremybeard