Fix the async execution mode read sql files for dbt packages #1588
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying astronomer-cosmos with
|
| Latest commit: |
43da5c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1206954.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://fix-read-path.astronomer-cosmos.pages.dev |
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajastro
force-pushed
the
fix_read_path
branch
from
c2b8b6d to
ab188e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
+ Coverage 97.36% 97.46% +0.10%
==========================================
Files 80 80
Lines 4934 4937 +3
==========================================
+ Hits 4804 4812 +8
+ Misses 130 125 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dosubot
bot
added
size:S
tatiana
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Hi @pankajastro , this is looking great, thank you very much!
Please, cover the areas that Codecov reported are lacking tests.
dosubot
bot
added
size:M
pankajastro
force-pushed
the
fix_read_path
branch
from
1c60e1e to
e7cddef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1585
This PR modifies the DbtNode to include the packages,
allowing us to correctly construct the path when reading
the generated SQL files. In DBT projects with dbt_packages,
the dbt run command generates SQL files within the respective
dbt_packages folder inside the target/run directory, instead of
the main project folder.
With Setup task
Without Setup task