Sometimes doesn't work with node version more than 12.19.x

[adevnadia]

It looks like that compiled might have a hard dependency on node version. In my current setup, which uses next.js and atlaskit components, the build in CI (github actions if important) started failing after I added @atlaskit/lozenge to the mix. Babel plugin is installed.

It was mitigated by reducing node version to the version 12.16.x from just 12.x. Not sure how to reproduce this setup in isolation without spending days on it, hope the description and the screen will help :)

UPD:

12.15.x node version - everything is good
12.19 - fails (so starts failing somewhere in between, probably when they enabled modules support by default)
14.15.1 (latest of 14.x) - still failing
15.5.1 (latest of 14.x) - still failing

UPD:
PR with the fix: #502

[itsdouges]

🤔

what version of compiled in your lock file?

(also hi!!!)

[adevnadia]

0.5.3

👋🏼 🙋🏼‍♀️

[itsdouges]

Re: Babel plugin being installed, we have a issue to remove it #493

for lozenge, it seems its calling to CJS is then calling out to the ESM compiled bundle... i wonder why?

main looks correct https://github.com/atlassian-labs/compiled/blob/master/packages/react/package.json#L14

is something prioritizing the module bundles?

[itsdouges]

this issue was raised in next which was fixed with the addition of adding CJS exports #387

is anything custom in your build setup? 🤔 (or alternatively any ideas what could be happening? hehe)

[adevnadia]

Iiiinteresting 🤔 In builds there is nothing special, just next build, next.js is latest. And webpack config is standard next.js with next-images config with the addition of babel-loader and a few plugins (magnetic-di and emotion).

Curious why newer node solves it, maybe they made some changes there?

[adevnadia]

Okay, I slightly bullshiting here, not the latest version, it's the opposite. Managed to miss that current recommended node is already 14x. After a bit of digging and CI abusing:

• 12.15.x node version - everything is good
• 12.19 - fails (so starts failing somewhere in between, probably when they enabled modules support by default)
• 14.15.1 (latest of 14.x) - still failing
• 15.5.1 (latest of 14.x) - still failing

[pgmanutd]

@adevnadia: I added this comment for packages which are not getting transpiled by next.js (which are coming from node_modules). Can you try solution mentioned here. Looks like they are using next-transpile-modules plugin for transpiling esm packages.

[adevnadia]

@pgmanutd found a better solution here: #502

@Madou if it doesn't break Atlaskit I expect a kudos from you 😝 😝 😝

[itsdouges]

Ohh!!! Awesome, I'll take a closer look soon Might also be good to add some more node versions into our CI run 🤔 it's already kind of configured just need to add extra versions in

…

On Wed, 13 Jan 2021, 7:44 pm Nadia Makarevich, ***@***.***> wrote: @pgmanutd <https://github.com/pgmanutd> found a better solution here: #502 <#502> @Madou <https://github.com/madou> if it doesn't break Atlaskit I expect a kudos from you 😝 😝 😝 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#501 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABT4PHMD2DDXW6D5DT3UWKTSZVMNPANCNFSM4WAI35EA> .

[pgmanutd]

Noice @adevnadia.