Changes persistence level to 'enterprise' on Windows

[jakobvogel]

Restores #123. Closes #168.

[bkostjens]

Any update on this PR?

[shiftkey]

@bkostjens it's on my list to review this week - I want to do some verification of this behaviour to better understand the migration story (if needed) myself...

[bkostjens]

@bkostjens it's on my list to review this week - I want to do some verification of this behaviour to better understand the migration story (if needed) myself...

Ah perfect! Thanks for your quick response.

[shiftkey]

I've tested out various upgrade/downgrade scenarios here and I'm happy this is a safe change. But to make this really clear to others I plan to ship this as part of a v5 beta to gather feedback later this week.

Thanks again for working through this with me @jakobvogel!

[jakobvogel]

Thank you @shiftkey! 👍

[shiftkey]

@jakobvogel https://github.com/atom/node-keytar/releases/tag/v5.0.0-beta.0 is available to test out and verify you're happy with the change.

[jakobvogel]

@jakobvogel https://github.com/atom/node-keytar/releases/tag/v5.0.0-beta.0 is available to test out and verify you're happy with the change.

I'll try it tomorrow and provide feedback here. Unfortunately, I currently don't have access to our Windows build machine. 😞

[jakobvogel]

I tried version 5.0.0 with our real product and everything works like a charm, both on macOS (where everything continues to work) and Windows (where credentials have enterprise persistence now). – Apart from the known issue #212, of course, but that does not matter to me too much right now.

So, I am very happy with version 5.0.0. 🎉 I am looking forward to retire our fork of the repository and move back to the official releases. Thanks again @shiftkey! 👍