This repository was archived by the owner on Jul 24, 2019. It is now read-only.
fixes #311: Glance ceph.enabled has no effect #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional case when Ceph should be disabled in Glance - that's when ceph.enabled is set to false.
|
good catch on this one too @dulek. @alanmeadows what is the status of your configuration overrides solution for glance? |
|
@dulek i think we're going to hold off on this PR until we're in openstack (next week). once we're there, @alanmeadows configuration overrides should really change the landscape, and development mode is out in favor of overrides and other tooling. we'll document these in the developer docs soon after our import into openstack. once you confirm, i'll mark with a flag of "do not merge" just so we know what's in and out. does that work for you? |
|
@v1k0d3n: Sure thing, this definitely collides with Glance conf override. |
|
closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?:
Fixing ceph.enabled having no effect on glance-api.conf and causing any image upload to fail without Ceph.
What issue does this pull request address?: Fixes #311
Notes for reviewers to consider:
Specific reviewers for pull request: