Keep domain compatible with gemini-3h #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
nazar-pc
reviewed
Mar 25, 2024
| // from the consensus block #168431, we have to follow this change in the client side to ensure | ||
| // every domain node that sync from genesis will produce the same ER and hence can successfully | ||
| // submit ER to exend the previous ER. | ||
| let maintain_runtime_inherent_extrinsic_order = parent_number >= 168430u32.into(); |
There was a problem hiding this comment.
You should also check that the chain is in fact Gemini 3h using genesis hash or something equivalent.
There was a problem hiding this comment.
Added code to determine if the node is running in gemini-3h by checking the genesis hash, and tested in gemini-3h.
Signed-off-by: linning <linningde25@gmail.com>
nazar-pc
reviewed
Mar 25, 2024
Comment on lines
+424
to
+430
| let is_gemini_3h = self.consensus_client.info().genesis_hash | ||
| == FromStr::from_str( | ||
| // The genesis hash of gemini-3h | ||
| "0c121c75f4ef450f40619e1fca9d1e8e7fbabc42c895bc4790801e85d5a91c34", | ||
| ) | ||
| .map_err(|_| ()) | ||
| .expect("parsing consensus block hash should success"); |
There was a problem hiding this comment.
Assuming parsing works, this should do the job, but even better way would be to define genesis has as [u8; 32] constant and store boolean result as a property of the data structure to not query info all the time since genesis hash never changes.
Signed-off-by: linning <linningde25@gmail.com>
nazar-pc
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes the recent domain incompatible issue with gemini-3h. The issue is due to the change of the order of the domain inherent extrinsic, the change is used to correct the order to keep consistency with the order on the fraud proof verification side, but because the change is on the client side, the domain node run with different release will produce different ER and trigger fraud proof.
The PR fixes the issue on gemini-3h by using the old order for consensus block <=
#168430and switching to the new order for consensus block >#168430, the block#168430is where the order changed in the ER chain on the consensus state.The second commit is some minor changes to add more detailed log for fraud proof.
Code contributor checklist: